Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo Numpy v2 #6035

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Demo Numpy v2 #6035

wants to merge 26 commits into from

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

We already know that Iris' syntax is NumPy v2 compliant, thanks to Ruff, but that does not prove that the code will all function with NumPy v2.

A vanilla Conda install of Iris does get NumPy v2, but unfortunately our full test environment does not (some of the dependencies must be pinned). So I have forced the issue by manually editing requirements/locks/py312-linux-64.lock, which does thankfully produce a working environment since none of NumPy's dependencies have changed.

The test failures show us what work we need to do for Iris to be compliant with NumPy v2. It seems to mostly be around changes in:

  • Handling of array dtypes
  • Array string representation
  • Array difference tolerances

Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@github-actions github-actions bot added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Jul 2, 2024
trexfeathers added a commit to trexfeathers/iris that referenced this pull request Jul 2, 2024
bjlittle pushed a commit that referenced this pull request Jul 3, 2024
* NEP29 NumPy pin.

* Pin back from NumPy v2 (#6035).

* PyPI pins.
@pp-mo pp-mo mentioned this pull request Jul 5, 2024
1 task
@trexfeathers trexfeathers added this to the v3.11 milestone Jul 8, 2024
@trexfeathers
Copy link
Contributor Author

Note to self: tests.test_ff.TestFF2PP2Cube.test_unit_pass_0 keeps flipping between expecting float32 or float64. I suspect a NumPy v2 change now means that something is no longer deterministic.

Copy link
Contributor

⏱️ Performance Benchmark Report: 7a969b1

Performance shifts
| Change   | Before [54f430bb]    | After [7a969b13]    |   Ratio | Benchmark (Parameter)                                                           |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------|
| -        | 1.36±0.01s           | 1.10±0.01s          |    0.81 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                   |
| -        | 1.38±0.01s           | 1.12±0.02s          |    0.81 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                    |
| -        | 743±10ms             | 540±30ms            |    0.73 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)             |
| -        | 733±20ms             | 510±20ms            |    0.7  | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)              |
| -        | 258±1ms              | 214±1ms             |    0.83 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500) |
| -        | 19.9±0.4ms           | 10.4±0.4ms          |    0.52 | stats.PearsonR.time_real                                                        |
| Change   | Before [54f430bb]    | After [7a969b13]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
| +        | 1.07±0.01ms          | 1.57±0.02ms         |    1.47 | import_iris.Iris.time_third_party_numpy |
| +        | 19.9±0.1M            | 24.4±0.3M           |    1.22 | stats.PearsonR.tracemalloc_lazy         |
Full benchmark results

Benchmarks that have improved:

| Change   | Before [54f430bb]    | After [7a969b13]    |   Ratio | Benchmark (Parameter)                                                           |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------|
| -        | 1.36±0.01s           | 1.10±0.01s          |    0.81 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                   |
| -        | 1.38±0.01s           | 1.12±0.02s          |    0.81 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                    |
| -        | 743±10ms             | 540±30ms            |    0.73 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)             |
| -        | 733±20ms             | 510±20ms            |    0.7  | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)              |
| -        | 258±1ms              | 214±1ms             |    0.83 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500) |
| -        | 19.9±0.4ms           | 10.4±0.4ms          |    0.52 | stats.PearsonR.time_real                                                        |

Benchmarks that have stayed the same:

| Change   | Before [54f430bb]    | After [7a969b13]    | Ratio   | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 63.2±1ms             | 63.4±2ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 63.9±0.9ms           | 64.0±0.9ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 235±2ms              | 234±5ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 237±4ms              | 233±1ms             | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 41.5±0.7ms           | 41.5±1ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 42.1±0.7ms           | 43.2±0.9ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 41.6±0.7ms           | 41.6±0.4ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 43.0±0.9ms           | 41.8±0.4ms          | 0.97    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 54.8±1ms             | 54.7±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 55.3±0.7ms           | 55.5±2ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 143±2ms              | 144±2ms             | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 144±2ms              | 143±3ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 59.6±1ms             | 59.5±1ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 61.0±0.8ms           | 60.7±2ms            | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 41.1±0.5ms           | 41.6±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 41.6±0.8ms           | 42.2±0.4ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 54.8±1ms             | 54.2±0.9ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 55.7±1ms             | 55.6±1ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 40.6±1ms             | 39.9±0.6ms          | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 40.7±0.6ms           | 40.3±0.7ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 73.2±0.5ms           | 72.6±2ms            | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 74.6±1ms             | 72.8±1ms            | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 76.4±1ms             | 74.5±1ms            | 0.97    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 76.9±2ms             | 74.5±1ms            | 0.97    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 71.9±1ms             | 70.3±1ms            | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 72.3±2ms             | 71.0±2ms            | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 28.3±0.6ms           | 28.0±0.9ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 32.3±0.7ms           | 33.1±1ms            | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 167±2ms              | 163±2ms             | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 187±5ms              | 179±2ms             | 0.96    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 26.6±0.6ms           | 26.1±0.6ms          | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 30.6±0.5ms           | 30.8±0.9ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 26.1±0.4ms           | 26.1±0.5ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 30.6±0.6ms           | 30.4±0.6ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 26.9±0.9ms           | 27.0±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 31.0±1ms             | 31.5±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 40.7±1ms             | 40.2±1ms            | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 45.3±0.4ms           | 44.8±0.9ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 27.1±0.5ms           | 28.1±1ms            | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 31.8±1ms             | 31.8±0.4ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 26.7±0.5ms           | 27.3±1ms            | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 31.3±0.5ms           | 32.3±0.9ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 26.9±0.5ms           | 27.0±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 31.0±0.7ms           | 32.1±1ms            | 1.04    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 587±5ms              | 550±6ms             | 0.94    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 591±2ms              | 552±1ms             | 0.93    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 184±4ms              | 178±2ms             | 0.97    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 203±3ms              | 202±3ms             | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 25.6±0.6ms           | 25.9±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 30.0±0.7ms           | 30.4±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 30.0±0.6ms           | 29.3±0.7ms          | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 34.4±0.7ms           | 33.6±0.7ms          | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 30.0±0.5ms           | 29.0±0.8ms          | 0.96    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 33.7±0.6ms           | 33.2±0.4ms          | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 28.9±0.3ms           | 28.0±0.5ms          | 0.97    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 33.0±0.8ms           | 33.1±0.8ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 99.6±1ms             | 97.9±1ms            | 0.98    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 101±0.8ms            | 98.3±1ms            | 0.98    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 114±1ms              | 113±1ms             | 0.99    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 116±2ms              | 113±1ms             | 0.97    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 68.1±0.9ms           | 66.3±1ms            | 0.97    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 69.2±0.7ms           | 68.1±0.9ms          | 0.98    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 33.5±0.5ms           | 33.2±1ms            | 0.99    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 38.1±0.8ms           | 37.2±0.6ms          | 0.98    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 36.2±1ms             | 35.4±1ms            | 0.98    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 40.0±0.8ms           | 40.2±1ms            | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 29.1±0.5ms           | 29.1±0.5ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 33.8±0.7ms           | 33.8±0.7ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 363±3ms              | 347±6ms             | 0.96    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 383±2ms              | 365±4ms             | 0.95    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.13±0.01ms          | 1.11±0.02ms         | 0.99    | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 393±5μs              | 396±3μs             | 1.01    | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 957±7μs              | 947±10μs            | 0.99    | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 580±5μs              | 573±6μs             | 0.99    | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 258±3ms              | 256±3ms             | 0.99    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 138±3ms              | 135±2ms             | 0.98    | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 269±5ms              | 283±3ms             | 1.05    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.6±0.2μs           | 16.8±0.2μs          | 1.01    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 374±5ms              | 370±5ms             | 0.99    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 251±5ms              | 248±2ms             | 0.99    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 380±5ms              | 401±6ms             | 1.05    | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 16.6±0.2μs           | 16.7±0.2μs          | 1.00    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 260±4ms              | 256±5ms             | 0.99    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 136±2ms              | 137±2ms             | 1.01    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 271±4ms              | 283±4ms             | 1.05    | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 53.1±0.4μs           | 53.8±0.5μs          | 1.01    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 375±4ms              | 370±5ms             | 0.99    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 250±4ms              | 249±3ms             | 0.99    | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 381±6ms              | 401±7ms             | 1.05    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 54.4±0.6μs           | 54.9±0.4μs          | 1.01    | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 822±7μs              | 817±10μs            | 0.99    | import_iris.Iris.time__concatenate                                                          |
|          | 196±6μs              | 191±5μs             | 0.98    | import_iris.Iris.time__constraints                                                          |
|          | 114±1μs              | 115±2μs             | 1.01    | import_iris.Iris.time__data_manager                                                         |
|          | 95.3±0.9μs           | 95.2±0.9μs          | 1.00    | import_iris.Iris.time__deprecation                                                          |
|          | 137±0.8μs            | 139±2μs             | 1.01    | import_iris.Iris.time__lazy_data                                                            |
|          | 945±10μs             | 938±10μs            | 0.99    | import_iris.Iris.time__merge                                                                |
|          | 77.4±1μs             | 78.7±1μs            | 1.02    | import_iris.Iris.time__representation                                                       |
|          | 643±20μs             | 632±9μs             | 0.98    | import_iris.Iris.time_analysis                                                              |
|          | 142±2μs              | 143±1μs             | 1.01    | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 111±0.6μs            | 111±1μs             | 1.00    | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 252±4μs              | 252±3μs             | 1.00    | import_iris.Iris.time_analysis__interpolation                                               |
|          | 193±3μs              | 195±1μs             | 1.01    | import_iris.Iris.time_analysis__regrid                                                      |
|          | 114±2μs              | 117±2μs             | 1.02    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 141±1μs              | 141±1μs             | 1.00    | import_iris.Iris.time_analysis_calculus                                                     |
|          | 339±6μs              | 339±3μs             | 1.00    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 95.8±2μs             | 95.1±0.8μs          | 0.99    | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 227±6μs              | 222±2μs             | 0.98    | import_iris.Iris.time_analysis_maths                                                        |
|          | 98.8±1μs             | 99.5±1μs            | 1.01    | import_iris.Iris.time_analysis_stats                                                        |
|          | 181±3μs              | 180±2μs             | 0.99    | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 330±10μs             | 326±9μs             | 0.99    | import_iris.Iris.time_aux_factory                                                           |
|          | 85.7±1μs             | 86.4±1μs            | 1.01    | import_iris.Iris.time_common                                                                |
|          | 169±2μs              | 172±4μs             | 1.01    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.38±0.03ms          | 1.42±0.04ms         | 1.03    | import_iris.Iris.time_common_metadata                                                       |
|          | 145±3μs              | 144±3μs             | 1.00    | import_iris.Iris.time_common_mixin                                                          |
|          | 1.22±0.01ms          | 1.23±0.01ms         | 1.01    | import_iris.Iris.time_common_resolve                                                        |
|          | 205±3μs              | 203±4μs             | 0.99    | import_iris.Iris.time_config                                                                |
|          | 127±2μs              | 126±1μs             | 1.00    | import_iris.Iris.time_coord_categorisation                                                  |
|          | 390±10μs             | 379±8μs             | 0.97    | import_iris.Iris.time_coord_systems                                                         |
|          | 797±20μs             | 806±20μs            | 1.01    | import_iris.Iris.time_coords                                                                |
|          | 739±20μs             | 718±30μs            | 0.97    | import_iris.Iris.time_cube                                                                  |
|          | 234±4μs              | 235±2μs             | 1.01    | import_iris.Iris.time_exceptions                                                            |
|          | 77.9±1μs             | 78.0±0.9μs          | 1.00    | import_iris.Iris.time_experimental                                                          |
|          | 186±2μs              | 187±2μs             | 1.00    | import_iris.Iris.time_fileformats                                                           |
|          | 259±5μs              | 268±4μs             | 1.03    | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.79±0.04ms          | 2.83±0.1ms          | 1.02    | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 80.5±0.9μs           | 81.0±1μs            | 1.01    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 117±1μs              | 118±2μs             | 1.01    | import_iris.Iris.time_fileformats_abf                                                       |
|          | 425±6μs              | 423±10μs            | 0.99    | import_iris.Iris.time_fileformats_cf                                                        |
|          | 5.80±0.1ms           | 5.92±0.1ms          | 1.02    | import_iris.Iris.time_fileformats_dot                                                       |
|          | 76.4±0.5μs           | 77.0±0.4μs          | 1.01    | import_iris.Iris.time_fileformats_name                                                      |
|          | 260±3μs              | 265±4μs             | 1.02    | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 123±2μs              | 123±1μs             | 1.00    | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 126±2μs              | 128±1μs             | 1.01    | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 215±4μs              | 219±3μs             | 1.02    | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 844±20μs             | 824±20μs            | 0.98    | import_iris.Iris.time_fileformats_pp                                                        |
|          | 181±4μs              | 187±3μs             | 1.03    | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 135±2μs              | 136±2μs             | 1.00    | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 534±10μs             | 529±4μs             | 0.99    | import_iris.Iris.time_fileformats_rules                                                     |
|          | 227±2μs              | 229±2μs             | 1.01    | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 83.5±2μs             | 85.9±0.9μs          | 1.03    | import_iris.Iris.time_fileformats_um                                                        |
|          | 167±3μs              | 166±2μs             | 0.99    | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 144±1μs              | 146±2μs             | 1.02    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 77.0±0.5μs           | 77.2±0.4μs          | 1.00    | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 83.7±0.9μs           | 83.9±0.8μs          | 1.00    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 1.01±0.01ms          | 1.02±0.01ms         | 1.01    | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 139±2μs              | 140±1μs             | 1.01    | import_iris.Iris.time_io                                                                    |
|          | 184±4μs              | 189±7μs             | 1.03    | import_iris.Iris.time_io_format_picker                                                      |
|          | 235±3μs              | 233±4μs             | 0.99    | import_iris.Iris.time_iris                                                                  |
|          | 132±3μs              | 128±2μs             | 0.97    | import_iris.Iris.time_iterate                                                               |
|          | 8.83±0.2ms           | 8.50±0.2ms          | 0.96    | import_iris.Iris.time_palette                                                               |
|          | 2.00±0.03ms          | 1.95±0.02ms         | 0.97    | import_iris.Iris.time_plot                                                                  |
|          | 104±2μs              | 105±1μs             | 1.01    | import_iris.Iris.time_quickplot                                                             |
|          | 2.37±0.05ms          | 2.43±0.1ms          | 1.03    | import_iris.Iris.time_std_names                                                             |
|          | 1.82±0.04ms          | 1.76±0.01ms         | 0.97    | import_iris.Iris.time_symbols                                                               |
|          | 103±2ms              | 102±2ms             | 0.99    | import_iris.Iris.time_tests                                                                 |
|          | 261±3μs              | 260±3μs             | 0.99    | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 4.96±0.07ms          | 4.98±0.07ms         | 1.00    | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 120±1μs              | 121±0.7μs           | 1.00    | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.87±0.02ms          | 2.92±0.06ms         | 1.02    | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 175±4μs              | 173±1μs             | 0.99    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 104±2μs              | 105±1μs             | 1.00    | import_iris.Iris.time_time                                                                  |
|          | 333±4μs              | 337±10μs            | 1.01    | import_iris.Iris.time_util                                                                  |
|          | 72.0±1μs             | 72.5±0.5μs          | 1.01    | iterate.IZip.time_izip                                                                      |
|          | 9.35±0.1ms           | 9.28±0.1ms          | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 28.0±0.4ms           | 27.2±0.2ms          | 0.97    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 10.4±0.2ms           | 9.38±0.1ms          | 0.90    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 9.26±0.1ms           | 9.15±0.3ms          | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 23.0±0.4ms           | 22.6±0.3ms          | 0.98    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 10.0±0.2ms           | 9.21±0.1ms          | 0.92    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.57±0.01s           | 1.56±0.01s          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 22.9±0.3ms           | 22.9±0.2ms          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.73±0.02s           | 1.59±0.02s          | 0.92    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.57±0.01s           | 1.56±0.01s          | 0.99    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 23.7±0.3ms           | 22.8±0.3ms          | 0.96    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.76±0.01s           | 1.58±0.01s          | 0.90    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 4.33±0.07ms          | 4.33±0.04ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 22.0±0.5ms           | 21.4±0.2ms          | 0.97    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 4.68±0.06ms          | 4.38±0.06ms         | 0.94    | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 4.39±0.07ms          | 4.41±0.08ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 22.0±0.5ms           | 21.0±0.3ms          | 0.96    | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 4.64±0.08ms          | 4.28±0.03ms         | 0.92    | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 37.5±3ms             | 28.3±3ms            | ~0.76   | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 21.6±0.5ms           | 22.6±1ms            | 1.05    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 14.8±2ms             | 14.4±2ms            | 0.97    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 26.7±1ms             | 27.3±1ms            | 1.02    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 80.2±0.8ms           | 79.1±2ms            | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 27.5±2ms             | 27.0±2ms            | 0.98    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 521±6ms              | 517±4ms             | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.39±0.08ms          | 3.38±0.2ms          | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 527±10ms             | 525±7ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 529±7ms              | 530±6ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.45±0.09ms          | 3.41±0.1ms          | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 533±10ms             | 526±3ms             | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.84±0.09ms          | 1.87±0.07ms         | 1.01    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.43±0.1ms           | 3.40±0.1ms          | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.94±0.2ms           | 1.80±0.07ms         | 0.93    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.90±0.1ms           | 1.83±0.07ms         | 0.97    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.41±0.09ms          | 3.44±0.09ms         | 1.01    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.95±0.1ms           | 1.84±0.1ms          | 0.94    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 365±3ms              | 364±2ms             | 1.00    | load.ManyVars.time_many_var_load                                                            |
|          | 9.52±0.08ms          | 9.36±0.06ms         | 0.98    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.3±0.1ms           | 9.35±0.1ms          | 0.91    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.58±0.01s           | 1.57±0.02s          | 1.00    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.75±0.01s           | 1.59±0.02s          | 0.91    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 4.41±0.02ms          | 4.39±0.09ms         | 0.99    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 4.70±0.04ms          | 4.39±0.05ms         | 0.93    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.24±0.1ms           | 9.25±0.2ms          | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 6.17±0.07ms          | 5.99±0.09ms         | 0.97    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.57±0.01s           | 1.55±0.01s          | 0.99    | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 547±6ms              | 543±6ms             | 0.99    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.40±0.08ms          | 4.36±0.04ms         | 0.99    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.31±0.06ms          | 4.31±0.06ms         | 1.00    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 169±0.6ms            | 168±1ms             | 0.99    | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 25.2±0.5ms           | 24.8±0.5ms          | 0.98    | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 183±2ms              | 169±2ms             | 0.92    | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 33.8±0.3ms           | 33.2±0.4ms          | 0.98    | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 25.4±0.4ms           | 24.5±0.2ms          | 0.97    | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 35.5±0.7ms           | 33.5±0.3ms          | 0.94    | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 19.2±0.6ms           | 19.3±0.3ms          | 1.00    | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 49.5±0.3ms           | 48.3±1ms            | 0.98    | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 15.9±0.5ms           | 15.8±0.2ms          | 0.99    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 27.5±0.7ms           | 27.6±0.9ms          | 1.00    | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 19.8±0.5ms           | 19.3±0.3ms          | 0.98    | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 24.5±0.4ms           | 24.7±0.4ms          | 1.01    | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 15.6±0.4ms           | 15.6±0.3ms          | 1.00    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 20.6±0.3ms           | 20.8±0.3ms          | 1.01    | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 20.5±0.5ms           | 20.6±0.4ms          | 1.00    | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 60.0±0.8ms           | 60.1±0.8ms          | 1.00    | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 20.9±0.3ms           | 20.4±0.4ms          | 0.98    | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 26.5±0.3ms           | 26.6±0.6ms          | 1.01    | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.42±0.1ms           | 3.34±0.08ms         | 0.97    | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 5.63±1ms             | 4.73±0.4ms          | 0.84    | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 43.4±1ms             | 42.9±1ms            | 0.99    | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 836±10ms             | 825±10ms            | 0.99    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 447±6ms              | 440±5ms             | 0.98    | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 444±3ms              | 438±4ms             | 0.99    | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 109±0.3M             | 109±0.4M            | 1.00    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.3M             | 109±0.4M            | 1.00    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 64.8±2ms             | 62.4±1ms            | 0.96    | merge_concat.Merge.time_merge                                                               |
|          | 758±300k             | 760±300k            | 1.00    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 483±5ns              | 471±3ns             | 0.97    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 655±2k               | 658±3k              | 1.00    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M              | 60.1±0M             | 1.00    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 17.1±0.2ms           | 17.5±0.3ms          | 1.02    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 19.5±0.3ms           | 19.0±0.5ms          | 0.98    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 499±20k              | 501±30k             | 1.00    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 12.4±0.02M           | 12.4±0.03M          | 1.00    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 127±3ms              | 127±2ms             | 1.00    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 754±10ms             | 699±10ms            | 0.93    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.24±0.02M           | 1.2±0.04M           | 0.97    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.3±0.04M           | 96.3±0.03M          | 1.00    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 83.8±1ms             | 83.0±2ms            | 0.99    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 703±4ms              | 652±8ms             | 0.93    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.16±0.02M           | 1.16±0.02M          | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.02M           | 96.2±0.02M          | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 7.01±0.1ms           | 6.89±0.1ms          | 0.98    | plot.AuxSort.time_aux_sort                                                                  |
|          | 86.0±4ms             | 88.2±2ms            | 1.02    | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              | 1.00    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 104±0.6ms            | 103±1ms             | 0.99    | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 55.2±2ms             | 55.3±2ms            | 1.00    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.04M            | 106±0.04M           | 1.00    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.02M            | 147±0.02M           | 1.00    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.96±0.2ms           | 4.82±0.09ms         | 0.97    | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 87.2±2ms             | 89.9±2ms            | 1.03    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 117±60ms             | 121±50ms            | 1.03    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 615±10ms             | 616±6ms             | 1.00    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 91.5±0.8ns           | 91.9±2ns            | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 68.7±2ms             | 69.3±2ms            | 1.01    | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 89.7±1ns             | 90.3±2ns            | 1.01    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 539±8ms              | 536±6ms             | 0.99    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 27.2±0.09k           | 27.9±0.06k          | 1.03    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.74±0.2M            | 1.7±0.2M            | 0.98    | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 27.2±0.1k            | 27.9±0.07k          | 1.03    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 208±20M              | 208±20M             | 1.00    | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 49.6±1ms             | 44.4±0.8ms          | 0.90    | stats.PearsonR.time_lazy                                                                    |
|          | 18.4±0.01M           | 18.4±0.01M          | 1.00    | stats.PearsonR.tracemalloc_real                                                             |
|          | 30.1±1ms             | 25.4±1ms            | 0.85    | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 70.9±0.9ms           | 63.5±0.9ms          | 0.89    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 23.3±0.01M           | 23.3±0.01M          | 1.00    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.05M           | 12.1±0.05M          | 1.00    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Benchmarks that have got worse:

| Change   | Before [54f430bb]    | After [7a969b13]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
| +        | 1.07±0.01ms          | 1.57±0.02ms         |    1.47 | import_iris.Iris.time_third_party_numpy |
| +        | 19.9±0.1M            | 24.4±0.3M           |    1.22 | stats.PearsonR.tracemalloc_lazy         |

Generated by GHA run 11366158747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant